Review Request 125117: Moved check for all mount points excluded out of widget class

[Thomas Lübking]

> On Sept. 15, 2015, 9:37 nachm., Vishesh Handa wrote:
> > kcms/baloo/kcm.cpp, line 168
> > <https://git.reviewboard.kde.org/r/125117/diff/4/?file=402375#file402375line168>
> >
> >     I'm really not too sure about this. So the display name is taken and that is compared with the mountPoint?
> >     
> >     The display name isn't always equal to the mount path or is it?
> >     
> >     http://doc.qt.io/qt-5/qstorageinfo.html#displayName
> 
> Ovidiu-Florin BOGDAN wrote:
>     From my tests I always got this result. I don't know on Windows though. Nor on Mac.

Nor on linux nor even on udisks. You can set the mountpoint to be completely different from the disks label.

Otoh, it seems more reasonable to operate on the labels anyway, doesn't? (it's just not "mountpointsExcluded"


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85465
-----------------------------------------------------------


On Sept. 9, 2015, 6:53 nachm., Ovidiu-Florin BOGDAN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125117/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 6:53 nachm.)
> 
> 
> Review request for Baloo, Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> And simplified the way it searches for the mount points.
> 
> 
> Diffs
> -----
> 
>   kcms/baloo/folderselectionwidget.h 6430b60 
>   kcms/baloo/folderselectionwidget.cpp 3ad1764 
>   kcms/baloo/kcm.h 6878e89 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125117/diff/
> 
> 
> Testing
> -------
> 
> Compiled and used.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150922/2e6fca17/attachment.html>