Review Request 125349: use a RowLayout for ToolbarLayout

[Marco Martin]

> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 37
> > <https://git.reviewboard.kde.org/r/125349/diff/1/?file=405034#file405034line37>
> >
> >     I would avoiding setting width and heights whilst in a RowLayout 
> >     
> >     as the Rowlayout will be overriding these properties at runtime so they're effectively ignored.

blah, leftover from the previos version :)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125349/#review85751
-----------------------------------------------------------


On Sept. 22, 2015, 2:35 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125349/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 2:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> more reliable.
> also put the first and last buttons at the extremes, the others in the middle as briefly discussed with the VDG in Randa
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml 4206bed 
> 
> Diff: https://git.reviewboard.kde.org/r/125349/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150922/4ef9ae91/attachment-0001.html>