Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

> On Sept. 16, 2015, 4:22 p.m., andreas kainz wrote:
> > Hi I add some applet icons in 256x256px in kde:breeeze (https://quickgit.kde.org/?p=breeze.git&a=commit&h=f75b729531a75df1536b7340fcb016a5752ebf69)
> > I need feedback how it looks and if it would work for you
> 
> Marco Martin wrote:
>     snapshot8 that's how the calendar svg looks on the current code
>     (had to copy it by hand as they are not installed atm, also i'm not sure applets/ subfolder in the icon theme would work)

for how iconloader works i think they should be in the apps folder, even tough technically thye are anot apps...


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85500
-----------------------------------------------------------


On Sept. 21, 2015, 1:20 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 1:20 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> As requested by the VDG, show screenshots in the widget explorer when available, to have a look similar to the activity manager (they'll do screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns instead of one, but that would need to be tested as well beforehand, both in the widget explorer and the activity switcher
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
>   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> snapshot6.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> more near to the intended design
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png
> snapshot8.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/16/23447d32-815e-48c0-9a00-3234ee28249e__snapshot8.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150921/6027b690/attachment.html>