Review Request 125006: Add individual monitor for each cpu option for system load viewer

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/#review85629
-----------------------------------------------------------



applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (line 87)
<https://git.reviewboard.kde.org/r/125006/#comment59170>

    what is the logic of preferredwidth here?
    don't use sizes in pixels
    
    should be done in worst case with units.gridUnit



applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (line 275)
<https://git.reviewboard.kde.org/r/125006/#comment59171>

    as style guidelines is always used the long notation
    if () {
        
    }


- Marco Martin


On Aug. 31, 2015, 8:13 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125006/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 8:13 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Yrjölä.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> When compact-bar monitos are selected the "show: CPUs separately" is enabled. When activated every cpu gets it's own monitor. The individual monitors try to fit in the space of two bars but when the number of cpus are too high the widht of the cpu monitors grow proportionally.
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml cb63fed 
> 
> Diff: https://git.reviewboard.kde.org/r/125006/diff/
> 
> 
> Testing
> -------
> 
> Running it on my own computer ;)
> 
> Issues:
> 1) When changing the CPUs separately setting the cpu column(s) size(s) are set to minimal and a restart of the applet is needed to get good loking layouts.
> 2) The tooltip does not fit all the cpu rows if the number of cpus are over 4 (6?).
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150918/49d8f907/attachment.html>