Review Request 125296: Intialise pointers

David Edmundson david at davidedmundson.co.uk
Fri Sep 18 10:59:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125296/
-----------------------------------------------------------

(Updated Sept. 18, 2015, 10:59 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 859c4ae66b3515999bca2e5c37c76003eeb2b854 by David Edmundson to branch Plasma/5.4.


Repository: plasma-desktop


Description
-------

data and data2 are pointers to data fetched from xigetproperty.

data2 is not always fetched, and thus may never be set.

This is important as any allocated data is XFree'd at the end of the
method.


Diffs
-----

  kcms/input/mouse.cpp c2bd0d0131339d835bf26f5e09768b96875c3142 

Diff: https://git.reviewboard.kde.org/r/125296/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150918/87ad785f/attachment.html>


More information about the Plasma-devel mailing list