Review Request 125295: Fix casting in mouse KCM init
David Edmundson
david at davidedmundson.co.uk
Fri Sep 18 10:59:44 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125295/
-----------------------------------------------------------
(Updated Sept. 18, 2015, 10:59 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit a3e5eb82e633c2530200176e81480b23ad289695 by David Edmundson to branch Plasma/5.4.
Repository: plasma-desktop
Description
-------
We fetch 32 bits of data in XIGetProperty
This should be casted into a Bool, which comes from Xlib which is set to
an int (also always 32 bits).
The current code casts it to Bool* which is arch dependent, meaning on
64 bit systems we just read random data.
Diffs
-----
kcms/input/mouse.cpp c2bd0d0131339d835bf26f5e09768b96875c3142
Diff: https://git.reviewboard.kde.org/r/125295/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150918/7fec62dd/attachment.html>
More information about the Plasma-devel
mailing list