Review Request 125129: Update baloo's D-Bus interface name in KCM

Pinak Ahuja pinak.ahuja at gmail.com
Fri Sep 18 09:17:11 UTC 2015



> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote:
> > Maybe we could just add this to our `IndexerConfig` class so that users of our API don't need to know about dbus interfaces? Specially since I'm not too keen on maintaining API comatibility in the dbus interface.

You mean adding a public method in IndexerConfig to update config?
updateConfig in mainhub also calls FileWatch::updateIndexedFoldersWatches()


- Pinak


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125129/#review85462
-----------------------------------------------------------


On Sept. 10, 2015, 5:56 a.m., Pinak Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125129/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 5:56 a.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Also generate interface from XML
> 
> 
> Diffs
> -----
> 
>   kcms/baloo/CMakeLists.txt 7415289 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125129/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pinak Ahuja
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150918/28ffd369/attachment.html>


More information about the Plasma-devel mailing list