Review Request 125296: Intialise pointers

Kai Uwe Broulik kde at privat.broulik.de
Thu Sep 17 20:57:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125296/#review85588
-----------------------------------------------------------


nullptr?

- Kai Uwe Broulik


On Sept. 17, 2015, 8:56 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125296/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 8:56 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> data and data2 are pointers to data fetched from xigetproperty.
> 
> data2 is not always fetched, and thus may never be set.
> 
> This is important as any allocated data is XFree'd at the end of the
> method.
> 
> 
> Diffs
> -----
> 
>   kcms/input/mouse.cpp c2bd0d0131339d835bf26f5e09768b96875c3142 
> 
> Diff: https://git.reviewboard.kde.org/r/125296/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150917/d38b0777/attachment.html>


More information about the Plasma-devel mailing list