Review Request 125287: Port KMix (mixer) dataengine to KF5

[David Edmundson]

> On Sept. 17, 2015, 11:58 a.m., David Edmundson wrote:
> > Porting seems fine.
> > 
> > Do you have any plans for this dataengine? Plasma landed it's own mixer, so wouldn't be using this.
> 
> Igor Poboiko wrote:
>     Still hoping there will be a proper KMix plasma applet. I might have some time to work on it (again? :D)
>     
>     Seems like KMix and that new mixer applet are completely unrelated, and they somehow conflict (right now there is two tray icons; if I close KMix - my shortcuts stop working; disabling KMix system tray is less than obvious). What are the plans on solving this issue?

>Seems like KMix and that new mixer applet are completely unrelated

In terms of code, yes. In terms of end user functionality, they both basically do the same thing.

>What are the plans on solving this issue?

The shortcuts are a tricky one. By design kglobalaccel will only give one app a global shortcut at time, and naturally they both want XF86AudioLowerVolume and such.
I think it's just a race to register.

TBH, I expect distros to only pick one, which also kinda resolves the conflict.

Can you swing by #plasma maybe? Might be good to have a discussion.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125287/#review85559
-----------------------------------------------------------


On Sept. 17, 2015, 10:31 a.m., Igor Poboiko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125287/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 10:31 a.m.)
> 
> 
> Review request for Plasma and Christian Esken.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2b89d92 
>   plasma/engine/CMakeLists.txt 198ef2b 
>   plasma/engine/mixerengine.cpp 22a35ab 
> 
> Diff: https://git.reviewboard.kde.org/r/125287/diff/
> 
> 
> Testing
> -------
> 
> Checked with plasmaengineexplorer - everything works as expected.
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150917/db9c1189/attachment-0001.html>