Review Request 125134: Add a role for screenshots in the widgetexplorer model

[Marco Martin]

> On Sept. 17, 2015, 1:30 p.m., Martin Gräßlin wrote:
> > components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h, line 55
> > <https://git.reviewboard.kde.org/r/125134/diff/1/?file=402570#file402570line55>
> >
> >     are you overriding a method here? If yes please add override. If no I'm suggesting to not use the same name as the virtual method.

it's an override


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125134/#review85573
-----------------------------------------------------------


On Sept. 17, 2015, 2:01 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125134/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 2:01 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As suggested by the VDG, add the possibility to have screenshots for plasmoids.
> the widget explorer will be modified as well to show the screenshots in the applet list when available
> 
> 
> Diffs
> -----
> 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 99e9add 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h f9cc89f 
> 
> Diff: https://git.reviewboard.kde.org/r/125134/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150917/d06e416a/attachment.html>