Review Request 125287: Port KMix (mixer) dataengine to KF5

David Edmundson david at davidedmundson.co.uk
Thu Sep 17 11:58:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125287/#review85559
-----------------------------------------------------------


Porting seems fine.

Do you have any plans for this dataengine? Plasma landed it's own mixer, so wouldn't be using this.

- David Edmundson


On Sept. 17, 2015, 10:31 a.m., Igor Poboiko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125287/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 10:31 a.m.)
> 
> 
> Review request for Plasma and Christian Esken.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2b89d92 
>   plasma/engine/CMakeLists.txt 198ef2b 
>   plasma/engine/mixerengine.cpp 22a35ab 
> 
> Diff: https://git.reviewboard.kde.org/r/125287/diff/
> 
> 
> Testing
> -------
> 
> Checked with plasmaengineexplorer - everything works as expected.
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150917/ded9c897/attachment.html>


More information about the Plasma-devel mailing list