Review Request 125256: kded_keyboard: Fix restoring application/window specific layout settings

[David Rosca]

> On Sept. 16, 2015, 1:11 p.m., David Edmundson wrote:
> > +1
> > 
> > given it's a behavioural change and I don't use keyboard layout switching (there is only one true layout!) I'd like someone else to comment on the session restoring. I can see arguments for both restoring and always starting from the same layout each time.
> 
> David Rosca wrote:
>     This only works when you set "Switching Policy" to Desktop, Application or Window and then you kind of expect it to remember the layouts (eg. I set US layout for konsole and CZ for everything else).
>     
>     It doesn't affect anything if you have "Switching Policy = Global", which is default.

I'm sorry, you were right. It does actually restore also current layout for global layouts.

So either we disable it for global policy (as it wasn't working before), or we can fix it. Imho it's better to fix it = no change to this patch.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125256/#review85495
-----------------------------------------------------------


On Sept. 16, 2015, 9:41 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125256/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 9:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 325572
>     https://bugs.kde.org/show_bug.cgi?id=325572
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This removes the check if user has restore session on start option enabled, so the layout map is restored everytime.
> 
> It also checks in LayoutMemory::laoutChanged if the changed keyboard layout is different from user configured to prevent clearing the layout map on startup.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/layout_memory.cpp 5ac6729 
>   kcms/keyboard/layout_memory_persister.cpp da48739 
> 
> Diff: https://git.reviewboard.kde.org/r/125256/diff/
> 
> 
> Testing
> -------
> 
> Per-application (or per-window) layouts are now preserved.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150916/8aacd778/attachment-0001.html>