Review Request 125226: move EventForge from the desktop containment

Marco Martin notmart at gmail.com
Wed Sep 16 16:44:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 4:44 p.m.)


Review request for KDE Frameworks, Plasma and Eike Hein.


Repository: kdeclarative


Description
-------

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150916/142bd676/attachment-0001.html>


More information about the Plasma-devel mailing list