Review Request 125117: Moved check for all mount points excluded out of widget class

Vishesh Handa me at vhanda.in
Tue Sep 15 21:37:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85465
-----------------------------------------------------------



kcms/baloo/kcm.cpp (line 168)
<https://git.reviewboard.kde.org/r/125117/#comment59063>

    I'm really not too sure about this. So the display name is taken and that is compared with the mountPoint?
    
    The display name isn't always equal to the mount path or is it?
    
    http://doc.qt.io/qt-5/qstorageinfo.html#displayName


- Vishesh Handa


On Sept. 9, 2015, 6:53 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125117/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 6:53 p.m.)
> 
> 
> Review request for Baloo, Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> And simplified the way it searches for the mount points.
> 
> 
> Diffs
> -----
> 
>   kcms/baloo/folderselectionwidget.h 6430b60 
>   kcms/baloo/folderselectionwidget.cpp 3ad1764 
>   kcms/baloo/kcm.h 6878e89 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125117/diff/
> 
> 
> Testing
> -------
> 
> Compiled and used.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150915/85fb2ae8/attachment.html>


More information about the Plasma-devel mailing list