Review Request 125248: Display name of process which blocks umount / eject

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125248/#review85458
-----------------------------------------------------------


Yes!! Thank you. Couple nitpickings below.


dataengines/devicenotifications/ksolidnotify.cpp (line 136)
<https://git.reviewboard.kde.org/r/125248/#comment59056>

    const QString &pid_s



dataengines/devicenotifications/ksolidnotify.cpp (line 138)
<https://git.reviewboard.kde.org/r/125248/#comment59057>

    ( pid ) --> (pid)



dataengines/devicenotifications/ksolidnotify.cpp (line 139)
<https://git.reviewboard.kde.org/r/125248/#comment59058>

    KSysGuard::Process* proc --> KSysGuard::Process *proc



dataengines/devicenotifications/ksolidnotify.cpp (lines 146 - 149)
<https://git.reviewboard.kde.org/r/125248/#comment59059>

    We put braces around if-else -->
    
    if () {
    
    } else {
    
    }



dataengines/devicenotifications/ksolidnotify.cpp (lines 178 - 201)
<https://git.reviewboard.kde.org/r/125248/#comment59060>

    It would appear that this is a duplicated function, please make it a function and then just call that function in both places


Y

- Martin Klapetek


On Sept. 15, 2015, 10:50 p.m., Igor Poboiko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125248/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 10:50 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> An attempt to implement feature from [bug 96107](https://bugs.kde.org/show_bug.cgi?id=96107) (see summary).
> 
> On umount/eject error it runs "lsof" executable, gets PIDs of blocking processes and obtains names of processes via KSysGuard::Process machinery. Finally it appends obtained information to error message which is shown in tooltip of Device Notifier applet.
> 
> 
> Diffs
> -----
> 
>   dataengines/devicenotifications/CMakeLists.txt 3f7fd83 
>   dataengines/devicenotifications/ksolidnotify.cpp 35d49d6 
> 
> Diff: https://git.reviewboard.kde.org/r/125248/diff/
> 
> 
> Testing
> -------
> 
> Tested unmount on busy device with several processes blocking it. Did not test eject, since I have no optical disc drive :(
> 
> 
> File Attachments
> ----------------
> 
> Applet with error message
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/15/3b1b64fc-abff-4633-9dca-621388edf086__snapshot11.png
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150915/44da48c3/attachment-0001.html>