[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

[Weng Xuetian]

https://bugs.kde.org/show_bug.cgi?id=350676

--- Comment #16 from Weng Xuetian <wengxt at gmail.com> ---
(In reply to Igor Poboiko from comment #15)
> (In reply to Weng Xuetian from comment #14)
> > FYI, https://git.reviewboard.kde.org/r/125182/
> What's the status of that patch? 
> That check was there from very beginning, as far as I can see from git log. 
> But I guess it shouldn't be there. Seems like the logic there is following:
> if cache is somehow broken, we should update a cache, but ignore a keypress.
> I believe it's not a correct behavior. We should just update a cache and
> keep going!
> And removing that check would have also solved that issue as well.
You may want to comment on the review instead of discuss at the bug report
here.
The reason that I don't want to update the cachedBrightness is, other usage of
it shows that it always keeps real hardware brightness value with in it is used
to whether to send brightness changed signal or not. From existing code, it
seems that the code tries to avoid querying hardware value frequently and send
a lot of brightness changed during animation.

The reason that the animation value is fake is because something like this may
happen: you set 35 to hardware, but hardware probably gives you 30 in the end.

-- 
You are receiving this mail because:
You are the assignee for the bug.