Review Request 125240: Use lineedit svg margins in sizeHint calculation

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125240/#review85446
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Sept. 15, 2015, 1:50 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125240/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 1:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> QQC button heights are max(backgroundHeight, label + margins).
> QQC lineedits heights are set from the background, ignoring the margins for size. Only using it for the offset of the TextInput within the frame.
> 
> We need to take the margins into consideration when deciding how high
> the textbox should be otherwise we're effectively just ignoring the SVG theme. 
> 
> This means button and textbox on the login screen are now the same
> height \o/. 
> 
> I had always assumed till now it was deliberate / the SVG hints were wrong.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 8daaa0b8355947cba920106f9d1cae3f3adb0200 
>   tests/components/button.qml 55d7dfbe9424736db56a1ebce5771a4592e20a98 
> 
> Diff: https://git.reviewboard.kde.org/r/125240/diff/
> 
> 
> Testing
> -------
> 
> Looked at some applets and stuff that used textboxes... all looked 2px higher. 
> 
> Shouldn't have any visible breakages as all existing code should have
> handled different themes with different heights anyway.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150915/6b2d5396/attachment.html>