Review Request 125195: Update the GTK icon cache when installing.

[Bhushan Shah]

> On Sept. 14, 2015, 9:47 p.m., Bhushan Shah wrote:
> > From packagers POV
> > 
> > Shouldn't this be handled by packages at post-install time? For example packages already update xdg icon resource cache in post install
> > 
> > I understand that on normal developers machine this post-install stuffs are not there. But then this needs to be optional
> 
> Volker Krause wrote:
>     Correct :)
>     
>     That's exactly what this patch is doing (the DESTDIR check disables it for packagers, so this is only for developer builds). The packages we checked indeed do this correctly already with post install hooks.

Oops, sorry for not reading properly.. :\

Also that made me discover breeze package in Arch Linux doesn't do that(!)


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125195/#review85383
-----------------------------------------------------------


On Sept. 14, 2015, 9:40 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125195/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 9:40 p.m.)
> 
> 
> Review request for Plasma and Olivier Goffart.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Despite the name this is also used by Qt, and considerably speeds up
> icon lookup.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d7ef4044880deb0b753238bc7d7ee0138a216bce 
>   cmake/GtkUpdateIconCache.cmake PRE-CREATION 
>   icons-dark/CMakeLists.txt 9793950db02826c9f31818e30ac91ec9ad93d43f 
>   icons/CMakeLists.txt 814b5ade4e5d185120a47fb72f2d5f531a7e8d41 
> 
> Diff: https://git.reviewboard.kde.org/r/125195/diff/
> 
> 
> Testing
> -------
> 
> Installed with and without existing cache, cache is correctly updated and ends up in the expected place.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150914/63e46636/attachment-0001.html>