Review Request 125120: support for the slide protocol

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/
-----------------------------------------------------------

(Updated Sept. 14, 2015, 1:19 p.m.)


Review request for kwin, Plasma and Eike Hein.


Repository: kwin


Description
-------

take and apply thhe informations from the wayland slide protocol in the sliding popups effect


Diffs (updated)
-----

  autotests/mock_effectshandler.h fba13cd 
  effects.h 97c2f87 
  effects.cpp f104410 
  effects/slidingpopups/slidingpopups.h ac3cf10 
  effects/slidingpopups/slidingpopups.cpp f6d9ec5 
  libkwineffects/kwineffects.h 20a0768 

Diff: https://git.reviewboard.kde.org/r/125120/diff/


Testing
-------

slide to appear works, slide out to disappear doesn't.

the second time a popup is opened, kwin crashes and an assert is hit

kwin_wayland: /home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, double) const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() && y1 >= top() && y2 <= bottom()' failed.


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150914/1abbfad1/attachment.html>