Review Request 125222: Plasma 5 Quicklaunch applet

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/
-----------------------------------------------------------

Review request for Plasma.


Repository: kdeplasma-addons


Description
-------

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set manually)


Diffs
-----

  applets/CMakeLists.txt 2e29bbe 
  applets/quicklaunch/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/Messages.sh PRE-CREATION 
  applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/plugin/qmldir PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125222/diff/


Testing
-------


File Attachments
----------------

Empty applet
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
On desktop (2 rows)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
On desktop with names + dragging
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
In vertical panel
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
Context menu
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150914/dc740a9a/attachment.html>