Review Request 125174: Plasma 5 Quicklaunch applet

[David Rosca]

> On Sept. 14, 2015, 9:35 a.m., Marco Martin wrote:
> > applets/quicklaunch-qml/package/contents/code/layout.js, line 23
> > <https://git.reviewboard.kde.org/r/125174/diff/1/?file=402772#file402772line23>
> >
> >     I guess the spacing here is half because it's used as margins for the items instead, so ends up being half+half..
> >     Maybe should be called itemPadding()?
> >     
> >     second, those being functions buried in a js file won't be updated in case one of the properties chnge..
> >     should they be in  qml file exposed as properties instead?

The code seems to work fine though, it correctly resize the launchers when size of applet is changed.

I'll rename the spacing() function.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85360
-----------------------------------------------------------


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Empty applet
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150914/46cb6532/attachment.html>