Review Request 125178: Don't fade animate icon in plasma tooltips

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125178/#review85354
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Sept. 11, 2015, 9:06 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125178/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 9:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> PlasmaCore.IconItem has a fade animation when changing source.
> This makes the plasma tooltip show old icon and then fade away to new icon when changing tooltip contents. It may be desirable when the tooltip is already visible and is changig its position and content to the new item (even though it still looks weird - text is changed immediately and icon only after a delay), but it is wrong when showing new tooltip.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/private/DefaultToolTip.qml 9c4a2cd 
> 
> Diff: https://git.reviewboard.kde.org/r/125178/diff/
> 
> 
> Testing
> -------
> 
> This weirdness is gone \o/
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150914/fbba8555/attachment.html>