Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

[Yoann Laissus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123818/
-----------------------------------------------------------

(Updated Sept. 13, 2015, 5:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 9b474a4ab01c3268048e29c336cf7b3fe9a83a47 by Yoann Laissus to branch master.


Repository: plasma-workspace


Description
-------

Currently, the size of devices is retrieved with solid.
Unfortunately, it doesn't work for network shares. Only the "StorageVolume" type has the "size" option.

KDiskFreeSpaceInfo supports every mounted device, not matter its type.


Diffs
-----

  applets/devicenotifier/package/contents/ui/FullRepresentation.qml 0a5b035d1afac368faf85f6dd0ff41bab4812562 
  dataengines/soliddevice/soliddeviceengine.h 85bdc68d4d7a9a8704d8ff1dcd29355c784ed435 
  dataengines/soliddevice/soliddeviceengine.cpp 94819c7405a3eb4b0ef679a55de2de20bd05fdb2 
  dataengines/soliddevice/soliddeviceservice.cpp f2f96ef4d63f41e3e2ea9bf31297adfcdf151a97 

Diff: https://git.reviewboard.kde.org/r/123818/diff/


Testing
-------

Tested with local disks, USB devices, NFS shares


Thanks,

Yoann Laissus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150913/ebae49a7/attachment.html>