Review Request 125200: Don't overflow action buttons in notification

David Edmundson david at davidedmundson.co.uk
Sat Sep 12 17:58:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125200/#review85269
-----------------------------------------------------------

Ship it!


There's a bug report somewhere which you should close with this.


applets/notifications/package/contents/ui/NotificationItem.qml (line 212)
<https://git.reviewboard.kde.org/r/125200/#comment58938>

    


- David Edmundson


On Sept. 12, 2015, 5:35 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125200/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 5:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Somehow the maximumWidth constraint is not propagated through the Repeater.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationItem.qml 350faa8 
> 
> Diff: https://git.reviewboard.kde.org/r/125200/diff/
> 
> 
> Testing
> -------
> 
> Buttons now respect the maximumWidth
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150912/c6b49d20/attachment.html>


More information about the Plasma-devel mailing list