Review Request 125191: Allow to set minimum user id lower than 1000

Wolfgang Bauer wbauer at tmo.at
Sat Sep 12 11:47:18 UTC 2015



> On Sept. 12, 2015, 1:41 nachm., David Edmundson wrote:
> > src/advanceconfig.cpp, line 33
> > <https://git.reviewboard.kde.org/r/125191/diff/1/?file=402959#file402959line33>
> >
> >     then change / remove this?

Well, this is also used as default value for the setting, see line 81.


- Wolfgang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125191/#review85249
-----------------------------------------------------------


On Sept. 12, 2015, 1:35 nachm., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125191/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 1:35 nachm.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 347942
>     https://bugs.kde.org/show_bug.cgi?id=347942
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> -------
> 
> Allow to set a minimum user id lower than 1000. Especially on older systems (and/or systems upgraded since years), the user ids might be below 1000 (e.g. on openSUSE, 500+ was the default years ago).
> 
> 
> Diffs
> -----
> 
>   src/advanceconfig.cpp 58e9f98 
> 
> Diff: https://git.reviewboard.kde.org/r/125191/diff/
> 
> 
> Testing
> -------
> 
> Set the minimum user id to 500 e.g., it does now get saved correctly.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150912/fe5b8329/attachment.html>


More information about the Plasma-devel mailing list