Review Request 125135: show screenshots in the widget explorer

Marco Martin notmart at gmail.com
Fri Sep 11 15:59:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/
-----------------------------------------------------------

(Updated Sept. 11, 2015, 3:59 p.m.)


Review request for Plasma and andreas kainz.


Changes
-------

code quality still WIP, gives an idea on the design


Repository: plasma-desktop


Description
-------

As requested by the VDG, show screenshots in the widget explorer when available, to have a look similar to the activity manager (they'll do screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns instead of one, but that would need to be tested as well beforehand, both in the widget explorer and the activity switcher


Diffs (updated)
-----

  desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
  desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 

Diff: https://git.reviewboard.kde.org/r/125135/diff/


Testing
-------


File Attachments
----------------

snapshot6.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
more near to the intended design
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150911/b49c0d2f/attachment.html>


More information about the Plasma-devel mailing list