Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
Eike Hein
hein at kde.org
Fri Sep 11 14:51:29 UTC 2015
> On Sept. 11, 2015, 11:12 a.m., Takahiro Hashimoto wrote:
> > I finally have had rights to commit KDE repos. If all are OK (already flaged 'Ship it' I understand), I'd like to commit it by myself:)
>
> Eike Hein wrote:
> Go ahead!
>
> Takahiro Hashimoto wrote:
> Thank you so much!! :)
Welcome to the team~
- Eike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125012/#review85170
-----------------------------------------------------------
On Sept. 11, 2015, 12:46 p.m., Takahiro Hashimoto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125012/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 12:46 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Now new Kicker dashboard's filterList isn't wraped by up/down key navigation.
> This simple patch make it enabled by setting 'keyNavigationWraps' property of ListView.
>
>
> Diffs
> -----
>
> applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837
>
> Diff: https://git.reviewboard.kde.org/r/125012/diff/
>
>
> Testing
> -------
>
> Press up key on the top of filterList menu. : highlight moved to bottom.
> Press down key on the bottom of filterList menu: highlight moved to top.
>
>
> Thanks,
>
> Takahiro Hashimoto
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150911/06afd369/attachment.html>
More information about the Plasma-devel
mailing list