Review Request 125161: Make the classic module optional and thus the dependencie to khtml.

Ben Cooksley bcooksley at kde.org
Fri Sep 11 12:49:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125161/#review85177
-----------------------------------------------------------

Ship it!


Looks fine to me.

- Ben Cooksley


On Sept. 11, 2015, 12:10 p.m., Patrick von Reth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125161/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 12:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> Make the classic module optional and thus the dependencie to khtml.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6bcd1b1b419a222350957b09bf715b6f88744889 
> 
> Diff: https://git.reviewboard.kde.org/r/125161/diff/
> 
> 
> Testing
> -------
> 
> Windows
> 
> 
> Thanks,
> 
> Patrick von Reth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150911/da1a9051/attachment.html>


More information about the Plasma-devel mailing list