Review Request 125138: do not crash when context gets defunct & implement respawn

Harald Sitter sitter at kde.org
Thu Sep 10 12:38:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125138/
-----------------------------------------------------------

(Updated Sept. 10, 2015, 12:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 8d36ea6a28b55dfc41cb05e1c09c4364353c4b84 by Harald Sitter to branch Plasma/5.4.


Repository: plasma-pa


Description
-------

context getting lost means we must destory all our references to pulse
objects. however we only nuked them from the map which incidentially didn't
remove them from the models so plasma/kcm would crash when trying to
refresh.

also implement respawn when the context dies, since no data isn't
particularly useful either

BUG: 351505


Diffs
-----

  src/context.h a8bf4673544b7de2802f360be4e88edccdc7d83c 
  src/context.cpp c09706a984eff4d34fea29869d96ce0cb68390af 
  src/maps.h 5c29c822da0cab45dbb5efb992d2d554374c6a1d 

Diff: https://git.reviewboard.kde.org/r/125138/diff/


Testing
-------

builds and doesnt crash no more


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150910/07598c34/attachment.html>


More information about the Plasma-devel mailing list