Review Request 125134: Add a role for screenshots in the widgetexplorer model

[Marco Martin]

> On Sept. 10, 2015, 10:39 a.m., Martin Gräßlin wrote:
> > I'm questioning the distribution of screenshots. Wouldn't it make more sense to generate it at runtime to show how it will look like (theme, proper dpi, etc.)?

i don't think it's feasible, it would have to load each single plasmoid in order to grab an image.
that means either screenshots are missing until the first time it's loaded or a very slow and expensive process is done the first time plasma starts (or each time a plasmoid is added)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125134/#review85096
-----------------------------------------------------------


On Sept. 10, 2015, 10:24 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125134/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 10:24 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As suggested by the VDG, add the possibility to have screenshots for plasmoids.
> the widget explorer will be modified as well to show the screenshots in the applet list when available
> 
> 
> Diffs
> -----
> 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 99e9add 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h f9cc89f 
> 
> Diff: https://git.reviewboard.kde.org/r/125134/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150910/bb628ab3/attachment.html>