Review Request 125134: Add a role for screenshots in the widgetexplorer model

Bhushan Shah bhush94 at gmail.com
Thu Sep 10 10:39:47 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125134/#review85095
-----------------------------------------------------------


+1 to idea in general

However I am not so sure about providing screenshot in package, given same plasmoid might look different in different form factor. What about having seperate data dir to provide the screenshots for plasmoid which can be extended later to provide say screenshots in different theme and/or different form factor?

- Bhushan Shah


On Sept. 10, 2015, 3:54 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125134/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As suggested by the VDG, add the possibility to have screenshots for plasmoids.
> the widget explorer will be modified as well to show the screenshots in the applet list when available
> 
> 
> Diffs
> -----
> 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 99e9add 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h f9cc89f 
> 
> Diff: https://git.reviewboard.kde.org/r/125134/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150910/51e9c9f5/attachment.html>


More information about the Plasma-devel mailing list