Review Request 125120: [wip] support for the slide protocol

Thu Sep 10 08:14:11 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125120/#review85091
-----------------------------------------------------------

For future references (opening kickoff multiple times triggers assert):

(gdb) bt
#0  0x00007fffedce0107 in __GI_raise (sig=sig at entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007fffedce14e8 in __GI_abort () at abort.c:89
#2  0x00007fffedcd9226 in __assert_fail_base (fmt=0x7fffede0fd08 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", 
    assertion=assertion at entry=0x7ffff7650b18 "x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() && y1 >= top() && y2 <= bottom()", 
    file=file at entry=0x7ffff76507a0 "/home/martin/src/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp", line=line at entry=908, 
    function=function at entry=0x7ffff7650f80 <KWin::WindowQuad::makeSubQuad(double, double, double, double) const::__PRETTY_FUNCTION__> "KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, double) const")
    at assert.c:92
#3  0x00007fffedcd92d2 in __GI___assert_fail (assertion=0x7ffff7650b18 "x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() && y1 >= top() && y2 <= bottom()", 
    file=0x7ffff76507a0 "/home/martin/src/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp", line=908, 
    function=0x7ffff7650f80 <KWin::WindowQuad::makeSubQuad(double, double, double, double) const::__PRETTY_FUNCTION__> "KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, double) const") at assert.c:101
#4  0x00007ffff7631dce in KWin::WindowQuad::makeSubQuad (this=0x1333980, x1=-1, y1=-12, x2=-1, y2=444.01579078981115) at /home/martin/src/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908
#5  0x00007ffff7632a1a in KWin::WindowQuadList::splitAtY (this=0x7fffffffbca8, y=444.01579078981115) at /home/martin/src/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:1050
#6  0x00007ffff71a058f in KWin::SlidingPopupsEffect::prePaintWindow (this=0x1a7e290, w=0x1c7daa0, data=..., time=1) at /home/martin/src/kf5/kde/workspace/kwin/effects/slidingpopups/slidingpopups.cpp:170
#7  0x00007ffff7a1684c in KWin::EffectsHandlerImpl::prePaintWindow (this=0x18b7890, w=0x1c7daa0, data=..., time=1) at /home/martin/src/kf5/kde/workspace/kwin/effects.cpp:442
#8  0x00007ffff79d031b in KWin::Scene::paintSimpleScreen (this=0x100f9d0, orig_mask=0, region=...) at /home/martin/src/kf5/kde/workspace/kwin/scene.cpp:303
#9  0x00007ffff79e8866 in KWin::SceneOpenGL2::paintSimpleScreen (this=0x100f9d0, mask=0, region=...) at /home/martin/src/kf5/kde/workspace/kwin/scene_opengl.cpp:1086
#10 0x00007ffff79cf6e2 in KWin::Scene::finalPaintScreen (this=0x100f9d0, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/scene.cpp:199
#11 0x00007ffff7a165d4 in KWin::EffectsHandlerImpl::paintScreen (this=0x18b7890, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/effects.cpp:411
#12 0x00007ffff7193961 in KWin::ScreenEdgeEffect::paintScreen (this=0x1904fd0, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/effects/screenedge/screenedgeeffect.cpp:81
#13 0x00007ffff7a16585 in KWin::EffectsHandlerImpl::paintScreen (this=0x18b7890, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/effects.cpp:408
#14 0x00007ffff762ee4d in KWin::Effect::paintScreen (this=0x1925cd0, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:537
#15 0x00007ffff7a16585 in KWin::EffectsHandlerImpl::paintScreen (this=0x18b7890, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/effects.cpp:408
#16 0x00007ffff762ee4d in KWin::Effect::paintScreen (this=0x1790e80, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:537
#17 0x00007ffff7a16585 in KWin::EffectsHandlerImpl::paintScreen (this=0x18b7890, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/effects.cpp:408
#18 0x00007ffff762ee4d in KWin::Effect::paintScreen (this=0x1a7e290, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:537
#19 0x00007ffff7a16585 in KWin::EffectsHandlerImpl::paintScreen (this=0x18b7890, mask=0, region=..., data=...) at /home/martin/src/kf5/kde/workspace/kwin/effects.cpp:408
#20 0x00007ffff79cf332 in KWin::Scene::paintScreen (this=0x100f9d0, mask=0x7fffffffc77c, damage=..., repaint=..., updateRegion=0x7fffffffc7d0, validRegion=0x7fffffffc7c0) at /home/martin/src/kf5/kde/workspace/kwin/scene.cpp:149
#21 0x00007ffff79e567c in KWin::SceneOpenGL::paint (this=0x100f9d0, damage=..., toplevels=...) at /home/martin/src/kf5/kde/workspace/kwin/scene_opengl.cpp:731
#22 0x00007ffff79c7557 in KWin::Compositor::performCompositing (this=0x71e6b0) at /home/martin/src/kf5/kde/workspace/kwin/composite.cpp:704
#23 0x00007ffff79c6d0c in KWin::Compositor::timerEvent (this=0x71e6b0, te=0x7fffffffd2f0) at /home/martin/src/kf5/kde/workspace/kwin/composite.cpp:607
#24 0x00007fffef30fe40 in QObject::event (this=0x71e6b0, e=0x7fffffffd2f0) at kernel/qobject.cpp:1220
#25 0x00007fffefe44616 in QApplicationPrivate::notify_helper (this=0x643210, receiver=0x71e6b0, e=0x7fffffffd2f0) at kernel/qapplication.cpp:3716
#26 0x00007fffefe41d75 in QApplication::notify (this=0x7fffffffd730, receiver=0x71e6b0, e=0x7fffffffd2f0) at kernel/qapplication.cpp:3160
#27 0x00007ffff7951841 in KWin::Application::notify (this=0x7fffffffd730, o=0x71e6b0, e=0x7fffffffd2f0) at /home/martin/src/kf5/kde/workspace/kwin/main.cpp:246
#28 0x00007fffef2d7f9e in QCoreApplication::notifyInternal (this=0x7fffffffd730, receiver=0x71e6b0, event=0x7fffffffd2f0) at kernel/qcoreapplication.cpp:965
#29 0x00007fffef2dbcbd in QCoreApplication::sendEvent (receiver=0x71e6b0, event=0x7fffffffd2f0) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:224
#30 0x00007fffef34c40a in QTimerInfoList::activateTimers (this=0x6676b8) at kernel/qtimerinfo_unix.cpp:637
#31 0x00007fffef34a2f5 in QEventDispatcherUNIX::activateTimers (this=0x64bfa0) at kernel/qeventdispatcher_unix.cpp:549
#32 0x00007fffef34a662 in QEventDispatcherUNIX::processEvents (this=0x64bfa0, flags=...) at kernel/qeventdispatcher_unix.cpp:611
#33 0x00007fffe07bc0c8 in QUnixEventDispatcherQPA::processEvents (this=0x64bfa0, flags=...) at eventdispatchers/qunixeventdispatcher.cpp:62
#34 0x00007fffef2d4b5c in QEventLoop::processEvents (this=0x7fffffffd520, flags=...) at kernel/qeventloop.cpp:128
#35 0x00007fffef2d4e50 in QEventLoop::exec (this=0x7fffffffd520, flags=...) at kernel/qeventloop.cpp:204
#36 0x00007fffef2d867c in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1229

- Martin Gräßlin

On Sept. 9, 2015, 9:27 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125120/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 9:27 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> take and apply thhe informations from the wayland slide protocol in the sliding popups effect
> 
> 
> Diffs
> -----
> 
>   effects/slidingpopups/slidingpopups.h ac3cf10 
>   effects/slidingpopups/slidingpopups.cpp f6d9ec5 
> 
> Diff: https://git.reviewboard.kde.org/r/125120/diff/
> 
> 
> Testing
> -------
> 
> slide to appear works, slide out to disappear doesn't.
> 
> the second time a popup is opened, kwin crashes and an assert is hit
> 
> kwin_wayland: /home/diau/git/kf5/kde/workspace/kwin/libkwineffects/kwineffects.cpp:908: KWin::WindowQuad KWin::WindowQuad::makeSubQuad(double, double, double, double) const: Assertion `x1 < x2 && y1 < y2 && x1 >= left() && x2 <= right() && y1 >= top() && y2 <= bottom()' failed.
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150910/b053642a/attachment-0001.html>