Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124980/#review85080
-----------------------------------------------------------



components/sessionsprivate/sessionsmodel.cpp (line 30)
<https://git.reviewboard.kde.org/r/124980/#comment58834>

    I don't see any usage of QDebug.



components/sessionsprivate/sessionsmodel.cpp (lines 82 - 83)
<https://git.reviewboard.kde.org/r/124980/#comment58833>

    we have a kcfg for this: please use the kcfg-compiler to not depend on get it to C++ code for reading the values. (see ksmserver/screenlocker)


- Martin Gräßlin


On Sept. 9, 2015, 10:28 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124980/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 10:28 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This way it can be used in the lock screen, user switcher, and a user switcher plasmoid I'm planning.
> 
> Compared to the one in the lock screen it can also get the user's full name and avatar, and some other information.
> 
> Perhaps we could also try to have it wait for the screen to actually lock before switching sessions?
> 
> 
> Diffs
> -----
> 
>   components/CMakeLists.txt 21fc61c 
>   components/sessionsprivate/CMakeLists.txt PRE-CREATION 
>   components/sessionsprivate/qmldir PRE-CREATION 
>   components/sessionsprivate/sessionsmodel.h PRE-CREATION 
>   components/sessionsprivate/sessionsmodel.cpp PRE-CREATION 
>   components/sessionsprivate/sessionsprivateplugin.h PRE-CREATION 
>   components/sessionsprivate/sessionsprivateplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124980/diff/
> 
> 
> Testing
> -------
> 
> Lists my sessions, allows to switch between them and start new ones. Locking when creating a new session is missing.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150910/6f7e2d64/attachment-0001.html>