Review Request 125127: add discover to favorties
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Sep 9 22:14:52 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125127/#review85075
-----------------------------------------------------------
Ship it!
+1 LGTM
- Aleix Pol Gonzalez
On Sept. 10, 2015, 12:11 a.m., Harald Sitter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125127/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 12:11 a.m.)
>
>
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> as requested by VDG
>
>
> Diffs
> -----
>
> applets/kickoff/core/favoritesmodel.cpp ce49939e2bfd7987ba9fd5cf2cdf8f64cc6e7afb
>
> Diff: https://git.reviewboard.kde.org/r/125127/diff/
>
>
> Testing
> -------
>
> none. too lazy.
>
> fwiw the discover notation is to prevent this breaking if aleix goes ahead with renaming muon-discover to discover in some future release
>
>
> Thanks,
>
> Harald Sitter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150909/b38fcbda/attachment-0001.html>
More information about the Plasma-devel
mailing list