Review Request 125117: Moved check for all mount points excluded out of widget class

Ovidiu-Florin BOGDAN ovidiu.b13 at gmail.com
Wed Sep 9 18:47:32 UTC 2015



> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote:
> > kcms/baloo/kcm.cpp, line 167
> > <https://git.reviewboard.kde.org/r/125117/diff/1/?file=402363#file402363line167>
> >
> >     const QStorageInfo &si
> 
> Ovidiu-Florin BOGDAN wrote:
>     If I do that I get this:
>     
>     /home/ovidiu/kde-devel/src/kde/workspace/plasma-desktop/kcms/baloo/kcm.cpp:167:5: error: invalid initialization of reference of type ‘QStorageInfo&’ from expression of type ‘const QStorageInfo’

I missed the const in front. Fixed now.


- Ovidiu-Florin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85057
-----------------------------------------------------------


On Sept. 9, 2015, 9:47 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125117/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 9:47 p.m.)
> 
> 
> Review request for Baloo, Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> And simplified the way it searches for the mount points.
> 
> 
> Diffs
> -----
> 
>   kcms/baloo/folderselectionwidget.h 6430b60 
>   kcms/baloo/folderselectionwidget.cpp 3ad1764 
>   kcms/baloo/kcm.h 6878e89 
>   kcms/baloo/kcm.cpp d85f615 
> 
> Diff: https://git.reviewboard.kde.org/r/125117/diff/
> 
> 
> Testing
> -------
> 
> Compiled and used.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150909/9b8a103f/attachment.html>


More information about the Plasma-devel mailing list