Review Request 125110: two small fixes for kwaylandScanner

Martin Gräßlin mgraesslin at kde.org
Wed Sep 9 05:58:28 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125110/#review85036
-----------------------------------------------------------

Ship it!


nice catches, thanks

- Martin Gräßlin


On Sept. 8, 2015, 11:42 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125110/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 11:42 p.m.)
> 
> 
> Review request for kwin, Plasma and Martin Gräßlin.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> - fix initializer type -- was hardcoded, seems like an oversight
> - add semicolons after class declarations -- one less thing to fix in the resulting code
> 
> 
> Diffs
> -----
> 
>   src/tools/generator.cpp 47e1343 
> 
> Diff: https://git.reviewboard.kde.org/r/125110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150909/5ee9cb96/attachment.html>


More information about the Plasma-devel mailing list