Review Request 124472: WIP: Implement drag and drop support for icon widget

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124472/#review85021
-----------------------------------------------------------



applets/icon/plugin/icon_p.cpp (line 111)
<https://git.reviewboard.kde.org/r/124472/#comment58807>

    QUrl::fromUserInput(droppedUrl.toString(), QString() QUrl::AssumeLocalFile) maybe?



applets/icon/plugin/icon_p.cpp (line 124)
<https://git.reviewboard.kde.org/r/124472/#comment58808>

    Make use of your stringUrl ;)



applets/icon/plugin/icon_p.cpp (line 159)
<https://git.reviewboard.kde.org/r/124472/#comment58809>

    The drop urls thingie from Dolphin (without Arks dndextract service):  
    
    KIO::DropJob *job = KIO::drop(QDropEvent *, m_url);
    KJobWidgets::setWindow(job, QWidget *);
    
    Is this what you want? :)


And thanks for this nice feature :)

- Emmanuel Pescosta


On Sept. 8, 2015, 8:37 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124472/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 8:37 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Brings back the ability to drop files onto a icon widget and have the associated application open it. Dropping something onto a folder does not yet work because it should use the konq menu thingie (Copy/Move/Link) but I don't want yet another copy of that (there's one in the folderview containment).
> 
> It should probably check already on drag enter whether it's a viable drop target (eg. executable or folder), also do some coding style cleanups I thought I had already committed earlier.
> 
> 
> Diffs
> -----
> 
>   applets/icon/package/contents/ui/main.qml 018105b 
>   applets/icon/plugin/icon_p.h ba2d9f7 
>   applets/icon/plugin/icon_p.cpp 18806fc 
> 
> Diff: https://git.reviewboard.kde.org/r/124472/diff/
> 
> 
> Testing
> -------
> 
> Dragged Gwenview onto the desktop, an icon was created.
> Dropped one picture onto it, Gwenview opened it.
> Dropped two pictures onto, Gwenview showed both.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150908/66375998/attachment.html>