Review Request 125105: Simplify getting associated apps list in AssociatedApplicationManager

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125105/#review85017
-----------------------------------------------------------

Ship it!


I would split it the mimetype-determination into a separate line of code for readability, but other than that, this looks good, thanks for having made and tested the change.

- David Faure


On Sept. 8, 2015, 3:05 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125105/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 3:05 p.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> As per dfaure's comment in https://git.reviewboard.kde.org/r/123779/ - it replaces KFileItemActions with KMimeTrader directly.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/associatedapplicationmanager.cpp 60ba596 
> 
> Diff: https://git.reviewboard.kde.org/r/125105/diff/
> 
> 
> Testing
> -------
> 
> The original bug (https://bugs.kde.org/show_bug.cgi?id=340326) remains fixed with this.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150908/29503f28/attachment.html>