Review Request 125018: Support for Dpms

Martin Gräßlin mgraesslin at kde.org
Tue Sep 8 12:18:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125018/
-----------------------------------------------------------

(Updated Sept. 8, 2015, 2:18 p.m.)


Review request for Plasma, Kai Uwe Broulik and Sebastian Kügler.


Changes
-------

* rebased on master
* fixed the typos
* improved documentation on the protocol


Repository: kwayland


Description
-------

Allows to retrieve the OutputInterface* for a given native wl_resource.
To support this we need to track the resources bound for each Output.

[server] Add a DpmsManagerInterface

Adding support for a org_kde_kwin_dpms interface. On server side
Dpms is mostly bound to the OutputInterface exposing just a very
small manager. Whether Dpms is supported and which mode is used is
tracked directly on the OutputInterface.

[client] Dpms protocol


[tests] Add an example for the Dpms interface

Uses QWidgets to render a very small UI.
* lists each Output
* for each output shows whether dpms is supported
* and which dpms mode it's in
* and provides a button to change the mode

[autotests] Extend tests for Dpms


Diffs (updated)
-----

  autotests/client/test_wayland_output.cpp cb2892a18c58eb1ebb2482fc76243876b7ea26a7 
  autotests/client/test_wayland_registry.cpp 53885d5907419cd541d08b79d65ba4a2f5d4aa2b 
  src/client/CMakeLists.txt 6c7a9c035e6e9c6ba7fc46aa90078bfc5e1401d6 
  src/client/dpms.h PRE-CREATION 
  src/client/dpms.cpp PRE-CREATION 
  src/client/protocols/dpms.xml PRE-CREATION 
  src/client/registry.h 30c9bcbcb91be885fadef1aabe6e9edf2aab56cc 
  src/client/registry.cpp 771cf53c2edb8044dad042f0e800b14c86f72cbd 
  src/server/CMakeLists.txt 73d6c83b815f664ed06b9c8467a87018c71eefbc 
  src/server/display.h e5f1ed58537f3a1042e2832b359a29b21aa8d9ad 
  src/server/display.cpp cfcc1fcede74b1030eed40ef18704584ac9fbe55 
  src/server/dpms_interface.h PRE-CREATION 
  src/server/dpms_interface.cpp PRE-CREATION 
  src/server/dpms_interface_p.h PRE-CREATION 
  src/server/output_interface.h 080ec7f7867795628f6ac243849d4ddd0c67e11a 
  src/server/output_interface.cpp ccf305d19a0b57cb5082d5e644c6bd83c0bfdd8d 
  tests/CMakeLists.txt 44712ece1a6a2d9566594fee910c711742c6ab01 
  tests/dpmstest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125018/diff/


Testing
-------

See added test application.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150908/ff25fbd3/attachment.html>


More information about the Plasma-devel mailing list