Review Request 125102: share the wayland connection between the effects and windowmanagement
Martin Gräßlin
mgraesslin at kde.org
Tue Sep 8 10:52:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125102/#review85005
-----------------------------------------------------------
src/windowsystem/waylandintegration.cpp (lines 86 - 87)
<https://git.reviewboard.kde.org/r/125102/#comment58794>
you need to check whether the wmInterface is valid. Please see docs on it.
- Martin Gräßlin
On Sept. 8, 2015, 12:49 nachm., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125102/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 12:49 nachm.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwayland-integration
>
>
> Description
> -------
>
> use a singleton to create the wayland connection and the interfaces.
> also create the interfaces only on demand
>
>
> Diffs
> -----
>
> src/windowsystem/CMakeLists.txt d95c05f
> src/windowsystem/waylandintegration.h PRE-CREATION
> src/windowsystem/waylandintegration.cpp PRE-CREATION
> src/windowsystem/windoweffects.h fe6424d
> src/windowsystem/windoweffects.cpp 365ccd4
> src/windowsystem/windowsystem.h 21777a9
> src/windowsystem/windowsystem.cpp 51db093
>
> Diff: https://git.reviewboard.kde.org/r/125102/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150908/e41a4f50/attachment.html>
More information about the Plasma-devel
mailing list