Review Request 125099: Fix documentation for gridUnit

Bhushan Shah bhush94 at gmail.com
Tue Sep 8 06:36:35 UTC 2015



> On Sept. 8, 2015, 12:04 p.m., David Edmundson wrote:
> > src/declarativeimports/core/units.h, lines 41-42
> > <https://git.reviewboard.kde.org/r/125099/diff/1/?file=402190#file402190line41>
> >
> >     size in which direction?

s/size of/width of/

If you don't mind I will fix it when commiting


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125099/#review84986
-----------------------------------------------------------


On Sept. 8, 2015, 9:39 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125099/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 9:39 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Unless I am mistaken, gridUnit clearly doesn't correspond to milimeter but size of M
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/units.h 6c038ba 
> 
> Diff: https://git.reviewboard.kde.org/r/125099/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150908/12a2ebe0/attachment-0001.html>


More information about the Plasma-devel mailing list