Review Request 124472: WIP: Implement drag and drop support for icon widget

Kai Uwe Broulik kde at privat.broulik.de
Mon Sep 7 18:55:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124472/
-----------------------------------------------------------

(Updated Sept. 7, 2015, 6:55 nachm.)


Review request for Plasma and Bhushan Shah.


Changes
-------

- Check application supported mime types
- Set plasmoid title and icon (this way when removing the widget the undo notification shows the proper app name and icon)


Repository: plasma-workspace


Description
-------

Brings back the ability to drop files onto a icon widget and have the associated application open it. Dropping something onto a folder does not yet work because it should use the konq menu thingie (Copy/Move/Link) but I don't want yet another copy of that (there's one in the folderview containment).

It should probably check already on drag enter whether it's a viable drop target (eg. executable or folder), also do some coding style cleanups I thought I had already committed earlier.


Diffs (updated)
-----

  applets/icon/package/contents/ui/main.qml 018105b 
  applets/icon/plugin/icon_p.h ba2d9f7 
  applets/icon/plugin/icon_p.cpp 18806fc 

Diff: https://git.reviewboard.kde.org/r/124472/diff/


Testing
-------

Dragged Gwenview onto the desktop, an icon was created.
Dropped one picture onto it, Gwenview opened it.
Dropped two pictures onto, Gwenview showed both.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150907/cf9af82b/attachment.html>


More information about the Plasma-devel mailing list