Review Request 125018: Support for Dpms

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125018/#review84952
-----------------------------------------------------------

Ship it!


Only minor things. Looking good otherwise.


src/client/dpms.h (line 93)
<https://git.reviewboard.kde.org/r/125018/#comment58767>

    hold -> held (passive)



src/client/dpms.h (line 95)
<https://git.reviewboard.kde.org/r/125018/#comment58768>

    anymore



src/client/dpms.h (line 98)
<https://git.reviewboard.kde.org/r/125018/#comment58769>

    set up



src/client/dpms.h (line 103)
<https://git.reviewboard.kde.org/r/125018/#comment58771>

    destroy instead of destroyed



src/client/dpms.h (line 172)
<https://git.reviewboard.kde.org/r/125018/#comment58772>

    held



src/client/dpms.h (line 174)
<https://git.reviewboard.kde.org/r/125018/#comment58773>

    anymore



src/client/dpms.h (line 182)
<https://git.reviewboard.kde.org/r/125018/#comment58774>

    destroy



src/client/dpms.h (line 208)
<https://git.reviewboard.kde.org/r/125018/#comment58775>

    on -> of?



src/client/dpms.h (line 234)
<https://git.reviewboard.kde.org/r/125018/#comment58776>

    Perhaps carry the new mode in this signal?



src/client/protocols/dpms.xml (line 30)
<https://git.reviewboard.kde.org/r/125018/#comment58766>

    I know these values make sense on an X11 level, not sure if there's really a difference between Standby and Suspend? (Please clarify)



src/client/protocols/dpms.xml (line 38)
<https://git.reviewboard.kde.org/r/125018/#comment58765>

    This event especially, but also all the other could use documentation. Either written here, or at least a pointer to the APIDOCS (which are there for the client bit).



src/server/output_interface.h (line 118)
<https://git.reviewboard.kde.org/r/125018/#comment58781>

    currently


- Sebastian Kügler


On Sept. 1, 2015, 12:05 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125018/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 12:05 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik and Sebastian Kügler.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> Allows to retrieve the OutputInterface* for a given native wl_resource.
> To support this we need to track the resources bound for each Output.
> 
> [server] Add a DpmsManagerInterface
> 
> Adding support for a org_kde_kwin_dpms interface. On server side
> Dpms is mostly bound to the OutputInterface exposing just a very
> small manager. Whether Dpms is supported and which mode is used is
> tracked directly on the OutputInterface.
> 
> [client] Dpms protocol
> 
> 
> [tests] Add an example for the Dpms interface
> 
> Uses QWidgets to render a very small UI.
> * lists each Output
> * for each output shows whether dpms is supported
> * and which dpms mode it's in
> * and provides a button to change the mode
> 
> [autotests] Extend tests for Dpms
> 
> 
> Diffs
> -----
> 
>   autotests/client/test_wayland_output.cpp cb2892a18c58eb1ebb2482fc76243876b7ea26a7 
>   autotests/client/test_wayland_registry.cpp a38066aeccec43edff26b10ebe89d31ede0f9a99 
>   src/client/CMakeLists.txt 7d0d38ab20be9d4c9becd64fb12d81480f6a8cf6 
>   src/client/dpms.h PRE-CREATION 
>   src/client/dpms.cpp PRE-CREATION 
>   src/client/protocols/dpms.xml PRE-CREATION 
>   src/client/registry.h c5956956db542737c9cd22c0823c1bc092dbfbef 
>   src/client/registry.cpp c7092642b308e6e49f4fd9515e87ffc1c8ea13a8 
>   src/server/CMakeLists.txt 1cf09d3ab636497c59d34a5c1acb8e95a4d2ea17 
>   src/server/display.h 4c0e0c71ef7c6bec8e24003a86e9ee12729babf9 
>   src/server/display.cpp 884d7ea2feb2a67a1eace58e279b5722186e6c17 
>   src/server/dpms_interface.h PRE-CREATION 
>   src/server/dpms_interface.cpp PRE-CREATION 
>   src/server/dpms_interface_p.h PRE-CREATION 
>   src/server/output_interface.h 080ec7f7867795628f6ac243849d4ddd0c67e11a 
>   src/server/output_interface.cpp ccf305d19a0b57cb5082d5e644c6bd83c0bfdd8d 
>   tests/CMakeLists.txt 44712ece1a6a2d9566594fee910c711742c6ab01 
>   tests/dpmstest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125018/diff/
> 
> 
> Testing
> -------
> 
> See added test application.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150907/b7cd365b/attachment-0001.html>