Review Request 125038: Make SourceModel writeable
David Kahles
david.kahles96 at gmail.com
Mon Sep 7 13:13:37 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125038/
-----------------------------------------------------------
(Updated Sept. 7, 2015, 3:13 p.m.)
Review request for Plasma and Harald Sitter.
Changes
-------
Don't loop through the signals, as we already stored them
Repository: plasma-pa
Description
-------
This is needed in order to change the input device volume from the applet
It's mostly copied and adjusted from the SinkModel.
It would be better to move this into the AbstractModel class, but I don't know how to do this, given that the moc can't handle templates.
Diffs (updated)
-----
src/pulseaudio.h e9402cfd2ea53290c1c2d00373bd5d5657c1bde5
src/pulseaudio.cpp 911088aab10dcc76208b7c36eaa60ab9b79298ad
Diff: https://git.reviewboard.kde.org/r/125038/diff/
Testing
-------
Changing the input volume from the applet works fine now (testes with skype and pavucontrol)
Thanks,
David Kahles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150907/c5c22305/attachment.html>
More information about the Plasma-devel
mailing list