Review Request 125038: Make SourceModel writeable

[David Kahles]

> On Sept. 7, 2015, 8:40 a.m., David Edmundson wrote:
> > src/pulseaudio.cpp, line 379
> > <https://git.reviewboard.kde.org/r/125038/diff/1/?file=400198#file400198line379>
> >
> >     int QMetaObject::indexOfSignal(const char * signal) const
> >     
> >     rather than looping

I will also change this for the SinkModel.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125038/#review84933
-----------------------------------------------------------


On Sept. 7, 2015, 2:11 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125038/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 2:11 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> This is needed in order to change the input device volume from the applet
> It's mostly copied and adjusted from the SinkModel.
> It would be better to move this into the AbstractModel class, but I don't know how to do this, given that the moc can't handle templates.
> 
> 
> Diffs
> -----
> 
>   src/pulseaudio.cpp 911088aab10dcc76208b7c36eaa60ab9b79298ad 
>   src/pulseaudio.h e9402cfd2ea53290c1c2d00373bd5d5657c1bde5 
> 
> Diff: https://git.reviewboard.kde.org/r/125038/diff/
> 
> 
> Testing
> -------
> 
> Changing the input volume from the applet works fine now (testes with skype and pavucontrol)
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150907/d5536033/attachment.html>