Review Request 125085: [applets/pager] Remove show dashboard option
David Edmundson
david at davidedmundson.co.uk
Mon Sep 7 07:10:13 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125085/#review84935
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Sept. 7, 2015, 7:07 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125085/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 7:07 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> The show dashboard features doesn't make sense any more as dashboard
> and show desktop are merged any way and show desktop already exists
> as an option. In addition the feature was broken anyway by calling
> D-Bus to plasma-desktop's dbus interface.
>
>
> Diffs
> -----
>
> applets/pager/package/contents/config/main.xml 100893380d7df1fbfb8a0e986fca7cf8ebd69612
> applets/pager/package/contents/ui/configGeneral.qml 1004c8ef2423a0cdaef962478e9900f1855c0eb6
> applets/pager/plugin/pager.h 83626a55cb62fb62f138619e14f73c5897c0b353
> applets/pager/plugin/pager.cpp 3119ef0fb4e70ab2513ca3db1b551d9e8f943f63
>
> Diff: https://git.reviewboard.kde.org/r/125085/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150907/51e39391/attachment-0001.html>
More information about the Plasma-devel
mailing list