Review Request 125062: Renamed variable for better description

Ovidiu-Florin BOGDAN ovidiu.b13 at gmail.com
Mon Sep 7 05:53:09 UTC 2015



> On Sept. 6, 2015, 5:26 p.m., Vishesh Handa wrote:
> > kcms/baloo/folderselectionwidget.cpp, line 129
> > <https://git.reviewboard.kde.org/r/125062/diff/1/?file=400390#file400390line129>
> >
> >     Does this actually compile? Because 'folderDisplayName' does not exist for me.

Oh, my, this diff is incomplete. I'll update it.


- Ovidiu-Florin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125062/#review84898
-----------------------------------------------------------


On Sept. 5, 2015, 11:05 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125062/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2015, 11:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This way the name of the variable is more descriptive with it's purpose.
> 
> 
> Diffs
> -----
> 
>   kcms/baloo/folderselectionwidget.cpp b44d111 
> 
> Diff: https://git.reviewboard.kde.org/r/125062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150907/21fe66c5/attachment.html>


More information about the Plasma-devel mailing list