Review Request 124923: Plasma 5 color picker plasmoid

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/#review84907
-----------------------------------------------------------


I would be for pushing this. I'mnot sure how to solve the disconnected look og the two buttons, but code wise seems fine

- Marco Martin


On Aug. 26, 2015, 6:07 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124923/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 6:07 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.
> 
> Clicking the "drop" (it's color-picker, I would expect a pipette icon) enters picker mode, where you can click anywhere on the screen and have the color code (in a format you can configure) copied to your clipboard.
> Clicking the color blob opens the history, showing the recentmost 9 colors (so it's a nice grid) which allow copying their respective color codes in various formats.
> Activating the plasmoid (pressing the configured shortcut) will by default enter color picking mode, alternatively it brings up the popup like any other plasmoid.
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt c60c350 
>   applets/colorpicker/CMakeLists.txt PRE-CREATION 
>   applets/colorpicker/Messages.sh PRE-CREATION 
>   applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
>   applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
>   applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
>   applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
>   applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
>   applets/colorpicker/package/metadata.desktop PRE-CREATION 
>   applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
>   applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
>   applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
>   applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
>   applets/colorpicker/plugin/qmldir PRE-CREATION 
>   applets/kolourpicker/CMakeLists.txt 522e0de 
>   applets/kolourpicker/Messages.sh 072def0 
>   applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
>   applets/kolourpicker/kolourpicker.h bde3ff7 
>   applets/kolourpicker/kolourpicker.cpp a4b0ea4 
>   applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 
> 
> Diff: https://git.reviewboard.kde.org/r/124923/diff/
> 
> 
> Testing
> -------
> 
> - I have the impression that the color picker is off by one pixel horizontally (QRect weirdness? or our Breeze crosshair cursor?)
> - I didn't test with multiple screens
> 
> 
> File Attachments
> ----------------
> 
> In a panel
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
> On the desktop
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
> History
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
> Formats menu
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
> Settings
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150906/66ed05ca/attachment.html>