Review Request 125058: Cleanup and Add directories to index list

[Martin Klapetek]

> On Sept. 5, 2015, 8:49 p.m., Vishesh Handa wrote:
> > kcms/baloo/folderselectionwidget.cpp, line 373
> > <https://git.reviewboard.kde.org/r/125058/diff/1/?file=400372#file400372line373>
> >
> >     `QStringLiteral`
> 
> Ovidiu-Florin BOGDAN wrote:
>     I didn't change that part.
>     
>     Why QStringLiteral instead of QLatin1String?

https://blog.qt.io/blog/2014/06/13/qt-weekly-13-qstringliteral/ and http://woboq.com/blog/qstringliteral.html


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125058/#review84876
-----------------------------------------------------------


On Sept. 5, 2015, 9:18 p.m., Ovidiu-Florin BOGDAN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125058/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2015, 9:18 p.m.)
> 
> 
> Review request for Baloo, Plasma, KDE Usability, Pinak Ahuja, and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Added the functionality to add directories to be indexed.
> Did some cleaning up.
> 
> 
> Diffs
> -----
> 
>   kcms/baloo/CMakeLists.txt 7415289 
>   kcms/baloo/configwidget.ui 512e4a5 
>   kcms/baloo/folderselectionwidget.h 226ab45 
>   kcms/baloo/folderselectionwidget.cpp b44d111 
>   kcms/baloo/kcm.h 6ff5813 
>   kcms/baloo/kcm.cpp 27d93e2 
> 
> Diff: https://git.reviewboard.kde.org/r/125058/diff/
> 
> 
> Testing
> -------
> 
> Tested add, remove include and exclude directories.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150905/2269aa06/attachment.html>