Review Request 125058: Cleanup and Add directories to index list

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125058/#review84861
-----------------------------------------------------------


Can you please attach some images of how the KCM now looks?


kcms/baloo/CMakeLists.txt 
<https://git.reviewboard.kde.org/r/125058/#comment58709>

    You seem to be using 'QStorageInfo' instead of Solid. Why?
    
    Also, if we decide that is what we want to do, it should in a separate patch. This patch is large and should be split.



kcms/baloo/configwidget.ui (line 43)
<https://git.reviewboard.kde.org/r/125058/#comment58711>

    Moving the checkBox from the top to bottom? Why? Also, if we want this it goes in a seperate patch.



kcms/baloo/folderselectionwidget.cpp (line 97)
<https://git.reviewboard.kde.org/r/125058/#comment58710>

    Is this change required?



kcms/baloo/folderselectionwidget.cpp (line 132)
<https://git.reviewboard.kde.org/r/125058/#comment58707>

    In the Qt coding style, getters do not have the word 'get'



kcms/baloo/folderselectionwidget.cpp (line 238)
<https://git.reviewboard.kde.org/r/125058/#comment58708>

    Coding style. The { should not be on the next line. Please fix all instances of this.


- Vishesh Handa


On Sept. 5, 2015, 11:33 a.m., Ovidiu-Florin BOGDAN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125058/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2015, 11:33 a.m.)
> 
> 
> Review request for Baloo, Plasma, Pinak Ahuja, and Vishesh Handa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Added the functionality to add directories to be indexed.
> Did some cleaning up.
> 
> 
> Diffs
> -----
> 
>   kcms/baloo/CMakeLists.txt 7415289 
>   kcms/baloo/configwidget.ui 512e4a5 
>   kcms/baloo/folderselectionwidget.h 226ab45 
>   kcms/baloo/folderselectionwidget.cpp b44d111 
>   kcms/baloo/kcm.h 6ff5813 
>   kcms/baloo/kcm.cpp 27d93e2 
> 
> Diff: https://git.reviewboard.kde.org/r/125058/diff/
> 
> 
> Testing
> -------
> 
> Tested add, remove include and exclude directories.
> 
> 
> Thanks,
> 
> Ovidiu-Florin BOGDAN
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150905/579c07e9/attachment.html>